fix: guard against IndexError when repr() returns empty string in formatPair() - #240
Merged
Conversation
formatPair() accessed value[0] unconditionally, crashing with IndexError when an object's __repr__ returns an empty string and the output is formatted across multiple lines (e.g. when the prefix is long). Add a len(value) >= 2 guard before the index access.
Collaborator
|
Thank you for the contribution! Will you have time to add tests for that case? |
Contributor
Author
|
Thanks for merging @Jakeroid! Yes — I'll open a follow-up PR with tests for the empty and single-char repr cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
formatPair()accessesvalue[0]unconditionally to check whether the stringified value looks like a Python string literal. When an object's__repr__returns an empty string'', this raisesIndexError: string index out of rangewhenever output is formatted across multiple lines (triggered by a long prefix, a long line, or a multiline value).Reproduction
Fix
Add a
len(value) >= 2guard before the character-index access so that empty (and single-character) strings skip the string-literal check instead of crashing.